Skip to content

Notification Settings adjustments#2249

Merged
andyra merged 6 commits intobasecamp:mainfrom
nqst:notification-settings-adjustments
Jan 7, 2026
Merged

Notification Settings adjustments#2249
andyra merged 6 commits intobasecamp:mainfrom
nqst:notification-settings-adjustments

Conversation

@nqst
Copy link
Contributor

@nqst nqst commented Dec 24, 2025

Changes:

  • Updated the title to use the singular form and capitalization (Notification Settings instead of Notifications settings).
  • Set the same top margin for the Notification Settings panel group as in Account Settings.
  • Normalized the corner radius in .notification__status so it looks more balanced with the parent .panel, especially on mobile.
  • Changed the Chrome label to Google Chrome in the "Help me fix this" instructions for macOS. This matches how it appears in System Settings and may save time when searching the list.
  • Added a missing comma.

Preview

Before After
push-before push-after
chrome-before chrome-after
Screenshot 2025-12-24 at 16 55 36@2x

P.S. Merry Christmas everyone! 🎄

@jorgemanrubia jorgemanrubia requested a review from andyra January 7, 2026 15:09
@jorgemanrubia
Copy link
Member

This looks good to me, what do you think @andyra?

@andyra
Copy link
Contributor

andyra commented Jan 7, 2026

👏 Lovely work, @nqst! Thanks for the improvements.

Aside: I wonder if there's a clever way to get corner radiuses to pair well with the .panel component—as long as we know the panel radius and padding value, it would be easy enough to calculate like so:

--inner-radius: calc(var(--panel-radius) - var(--panel-padding));

@andyra andyra merged commit f58bb33 into basecamp:main Jan 7, 2026
5 checks passed
@nqst
Copy link
Contributor Author

nqst commented Jan 14, 2026

Thanks @andyra!

I love the idea, but I think we still need to use the magic number. The default panel paddings are quite generous, so if we just subtract the current panel padding from its radius, we'll have an inner radius of 0.

I experimented a bit and ended up with this:

--panel-inner-border-radius: max(calc(var(--panel-border-radius) - var(--panel-padding)), 0.5em);

This way, the radius never gets too small.

If the parent panel radius is larger, it works as expected:

But since that's not the case, I'm not sure if it's worth making it more complex. I didn't open a PR, but you can see the working code here: main...nqst:fizzy:inner-panel-dynamic-radius

JustinBeaudry pushed a commit to Actual-Reality/fizzy that referenced this pull request Jan 22, 2026
…stments

Notification Settings adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants