Notification Settings adjustments#2249
Conversation
|
This looks good to me, what do you think @andyra? |
|
👏 Lovely work, @nqst! Thanks for the improvements. Aside: I wonder if there's a clever way to get corner radiuses to pair well with the .panel component—as long as we know the panel radius and padding value, it would be easy enough to calculate like so: --inner-radius: calc(var(--panel-radius) - var(--panel-padding)); |
|
Thanks @andyra! I love the idea, but I think we still need to use the magic number. The default panel paddings are quite generous, so if we just subtract the current panel padding from its radius, we'll have an inner radius of 0. I experimented a bit and ended up with this: --panel-inner-border-radius: max(calc(var(--panel-border-radius) - var(--panel-padding)), 0.5em);This way, the radius never gets too small. If the parent panel radius is larger, it works as expected:
But since that's not the case, I'm not sure if it's worth making it more complex. I didn't open a PR, but you can see the working code here: main...nqst:fizzy:inner-panel-dynamic-radius |
…stments Notification Settings adjustments

Changes:
.notification__statusso it looks more balanced with the parent.panel, especially on mobile.Preview
P.S. Merry Christmas everyone! 🎄